RFR: 8352418: Add verification code to check that the associated loop nodes of useless Template Assertion Predicates are dead [v2]

Emanuel Peter epeter at openjdk.org
Wed Apr 2 07:53:53 UTC 2025


On Wed, 2 Apr 2025 07:49:34 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> As already suggested in https://github.com/openjdk/jdk/pull/23823, I want to do the following additional verification:
>> 
>> After `eliminate_useless_predicates()` all now useless `OpaqueTemplateAssertionPredicate` nodes should not have any references to `CountedLoop` nodes that are still in the graph (otherwise, they would have been marked useful). This verification did not work reliably without the full Assertion Predicates fix [JDK-8350577](https://bugs.openjdk.org/browse/JDK-8350577). Since JDK-8350577 is now integrated, I propose to add this additional verification code.
>> 
>> Thanks,
>> Christian
>
> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add ResourceMark

Marked as reviewed by epeter (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/24326#pullrequestreview-2734966884


More information about the hotspot-compiler-dev mailing list