RFR: 8348887: Create IR framework test for JDK-8347997
Tobias Hartmann
thartmann at openjdk.org
Wed Apr 2 07:57:52 UTC 2025
On Wed, 2 Apr 2025 07:50:35 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> As the ticket says:
>>> Create IR framework test which checks that allocations are eliminated in the regression test included in [JDK-8347997](https://bugs.openjdk.org/browse/JDK-8347997) fix.
>>
>> So here it is! We can see that in case of inlining, indeed, no allocation happens. The second part is some sanity check to emphasize the difference: of course, there is an allocation without inlining. The benefit of this second part is arguable. From my point of view, it's mostly to point out the difference to a future reader. But yes, there is nothing very surprising.
>>
>> Thanks,
>> Marc
>
> test/hotspot/jtreg/compiler/c2/irTests/TestContinuationPinningAndEA.java line 51:
>
>> 49: try {
>> 50: test_FailsEA();
>> 51: } catch (Throwable _) {
>
> These should normally not throw, right? I would just propagate the exception upwards. Otherwise we risk hiding real issues.
And isn't `Exception` or a subclass sufficient?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24328#discussion_r2024276355
More information about the hotspot-compiler-dev
mailing list