RFR: 8348887: Create IR framework test for JDK-8347997 [v2]
Tobias Hartmann
thartmann at openjdk.org
Wed Apr 2 10:46:05 UTC 2025
On Wed, 2 Apr 2025 10:03:30 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:
>> As the ticket says:
>>> Create IR framework test which checks that allocations are eliminated in the regression test included in [JDK-8347997](https://bugs.openjdk.org/browse/JDK-8347997) fix.
>>
>> So here it is! We can see that in case of inlining, indeed, no allocation happens. The second part is some sanity check to emphasize the difference: of course, there is an allocation without inlining. The benefit of this second part is arguable. From my point of view, it's mostly to point out the difference to a future reader. But yes, there is nothing very surprising.
>>
>> Thanks,
>> Marc
>
> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove catch, rename, remove static
Thanks for making these changes, looks good to me.
test/hotspot/jtreg/compiler/c2/irTests/TestContinuationPinningAndEA.java line 41:
> 39: public class TestContinuationPinningAndEA {
> 40: public static void main(String[] args) {
> 41: TestFramework.runWithFlags("--add-modules", "java.base", "--add-exports", "java.base/jdk.internal.vm=ALL-UNNAMED");
Why is this only needed now?
-------------
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24328#pullrequestreview-2735827767
PR Review Comment: https://git.openjdk.org/jdk/pull/24328#discussion_r2024569397
More information about the hotspot-compiler-dev
mailing list