RFR: 8352869: Verify.checkEQ: extension for NaN, VectorAPI and arbitrary Objects [v7]

[Emanuel Peter]

On Thu, 3 Apr 2025 06:06:50 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/lib/verify/Verify.java line 187:
>> 
>>> 185:     private void checkEQimpl(char a, char b, String field, Object aParent, Object bParent) {
>>> 186:         if (a != b) {
>>> 187:             System.err.println("ERROR: Verify.checkEQ failed: value mismatch: " + (int)a + " vs " + (int)b);
>> 
>> Why do you need an upcast here? Same for `short`.
>
> Look at this ;)
> 
> jshell> char a = 66;
> a ==> 'B'
> 
> jshell> System.out.println("a: " + a);
> a: B
> 
> jshell> System.out.println("a: " + (int)a);
> a: 66
> 
> 
> But I can remove the casts for `short`.

Added a comment as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24224#discussion_r2026271338