RFR: 8352585: Add special case handling for Float16.max/min x86 backend [v8]
Emanuel Peter
epeter at openjdk.org
Thu Apr 3 09:25:37 UTC 2025
On Thu, 3 Apr 2025 09:22:23 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> This bugfix patch adds the special handling as per x86 AVX512-FP16 ISA specification[1][2] to compute max/min operations with +/-0.0 or NaN operands.
>>
>> Special handling leverage the instruction semantic, central idea is to shuffle the operands such that smaller input gets assigned to second operand for min operation or a larger input gets assigned to second operand for max operation, in addition result equals NaN if an unordered comparison detects first input as a NaN value else we return the result of min/max operation.
>>
>> Kindly review and share your feedback.
>>
>> Best Regards,
>> Jatin
>>
>> [1] https://www.felixcloutier.com/x86/vminsh
>> [2] https://www.felixcloutier.com/x86/vmaxsh
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>
> Type fixes
Marked as reviewed by epeter (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/24169#pullrequestreview-2739096032
More information about the hotspot-compiler-dev
mailing list