RFR: 8352585: Add special case handling for Float16.max/min x86 backend [v7]
Jatin Bhateja
jbhateja at openjdk.org
Thu Apr 3 09:25:38 UTC 2025
On Thu, 3 Apr 2025 09:01:57 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments resolution
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 7129:
>
>> 7127: // dst = min(xtmp1, xtmp2)
>> 7128: vminsh(dst, xtmp1, xtmp2);
>> 7129: // isNaN = is_unordered_quite(xtmp1)
>
> Suggestion:
>
> // isNaN = is_unordered_quiet(xtmp1)
Typo fixed. Thanks
Needs re-approval :-)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24169#discussion_r2026558934
More information about the hotspot-compiler-dev
mailing list