RFR: 8349479: C2: when a Type node becomes dead, make CFG path that uses it unreachable [v7]

Roland Westrelin roland at openjdk.org
Thu Apr 3 12:45:19 UTC 2025


On Tue, 1 Apr 2025 08:42:12 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> The callers have the `ResourceMark`. This is because it's code I extracted from 8275202: I think it used to not be safe to call `PhaseIdealLoop::register_new_node` from within the `ResourceMark` but I see there were changes in that area (data structures used by `PhaseIdealLoop` no longer allocated in the resource area). So it looks like it could be changed now.
>
> I assume that JDK-8275202 also calls this method with a non-null `PhaseIdealLoop` pointer? Now we only pass in null, so the `loop` parameter could be removed.

Right. Do you think it's better to remove the parameter that's used (for now)?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23468#discussion_r2026910749


More information about the hotspot-compiler-dev mailing list