RFR: 8353665: RISC-V: IR verification fails in TestSubNodeFloatDoubleNegation.java

Hamlin Li mli at openjdk.org
Thu Apr 3 17:02:22 UTC 2025


Hi,
Can you help to review this patch?
The newly added TestSubNodeFloatDoubleNegation.java (in https://github.com/openjdk/jdk/pull/24150) is to check `0 - (0 - x)` is not folded to `x` for float and double.
I have manually checked the IR and generated assembly code, it's not folded on riscv either, just there is an extra SubF in some code path.
So, the fix for this test on riscv should be simply make the check as `>= 2` rather than `2`.

Tested on both x86 and riscv64.

Thanks

-------------

Commit messages:
 - initial commit

Changes: https://git.openjdk.org/jdk/pull/24421/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24421&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8353665
  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/24421.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24421/head:pull/24421

PR: https://git.openjdk.org/jdk/pull/24421


More information about the hotspot-compiler-dev mailing list