RFR: 8346836: C2: Introduce a way to verify the correctness of ConstraintCastNodes at runtime [v5]

[Quan Anh Mai]

On Fri, 7 Feb 2025 17:10:46 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Merge branch 'master' into verifycast
>>  - better comments
>>  - move test to a new file, add block_comment
>>  - add tests
>>  - make VerifyConstraintCast uint, better debug info
>>  - Merge branch 'master' into verifycast
>>  - Introduce VerifyConstraintCasts
>
> src/hotspot/share/opto/c2_globals.hpp line 666:
> 
>> 664:           "perform extra checks on the results of alias analysis")          \
>> 665:                                                                             \
>> 666:   develop(uint, VerifyConstraintCasts, 0,                                   \
> 
> Any downsides in making the flag diagnostic? It'll make it available in product builds.

That's a great idea, done it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22880#discussion_r2029787586