RFR: 8352869: Verify.checkEQ: extension for NaN, VectorAPI and arbitrary Objects [v12]

Andrey Turbanov aturbanov at openjdk.org
Sat Apr 5 18:05:55 UTC 2025


On Thu, 3 Apr 2025 08:15:36 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> We should extend the functionality of Verify.checkEQ:
>> - Allow different NaN encodings to be seen as equal (by default).
>> - Compare VectorAPI vectors.
>> - Compare Exceptions, and their messages.
>> - Compare arbitrary Objects via Reflection.
>> 
>> Note: this is a prerequisite for the Template Library [JDK-8352861](https://bugs.openjdk.org/browse/JDK-8352861) / https://github.com/openjdk/jdk/pull/23418.
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   For Christian

test/hotspot/jtreg/compiler/lib/verify/Verify.java line 499:

> 497:         // Hence, we cannot use the mapping below. We test these boxed primitive types by value anyway,
> 498:         // and they are no recursive structures, so there is no point in optimizing here anyway.
> 499:         switch(a) {

Suggestion:

        switch (a) {

test/hotspot/jtreg/testlibrary_tests/verify/tests/TestVerify.java line 528:

> 526:     }
> 527: 
> 528:     public static class H1  {

Suggestion:

    public static class H1 {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24224#discussion_r2029936364
PR Review Comment: https://git.openjdk.org/jdk/pull/24224#discussion_r2029936226


More information about the hotspot-compiler-dev mailing list