RFR: 8348645: IGV: visualize live ranges [v4]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Mon Apr 7 08:10:58 UTC 2025
On Fri, 7 Mar 2025 09:44:12 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> Just a minor aesthetic thing: I noticed that in phases with no liveness information, the liveness information in each node is replaced by an empty space (instead of nothing):
>> <img width="254" alt="image" src="https://github.com/user-attachments/assets/bc09baab-bc91-4f15-838a-3fa7cbb8097b" />
>> instead of
>> <img width="266" alt="image" src="https://github.com/user-attachments/assets/1b1d53ea-59bc-425d-b1f2-a010562463b6" />
>>
>>
>> Otherwise it looks good to me (I probably made more of a functionality rather than a code style/semantics kind of review). Thanks again @robcasloz.
>
>> Just a minor aesthetic thing: I noticed that in phases with no liveness information, the liveness information in each node is replaced by an empty space (instead of nothing)
>
> Good catch, thanks Damon! Commit efbde14a should address that, please check that it works as you expect.
> @robcasloz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
💓
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23558#issuecomment-2782386813
More information about the hotspot-compiler-dev
mailing list