RFR: 8353192: C2: Clean up x86 backend after 32-bit x86 removal

Aleksey Shipilev shade at openjdk.org
Mon Apr 7 08:31:49 UTC 2025


On Thu, 3 Apr 2025 17:06:16 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Piece-wise cleanup of C2 x86 backend. C2_MacroAssembler, x86.ad and related files are the target for this cleanup. 
>> 
>> Additional testing:
>>  - [x] Linux x86_64 server fastdebug, `all`
>>  - [x] Linux x86_64 server fastdebug, `all` + `-XX:-TieredCompilation`
>
> src/hotspot/cpu/x86/x86.ad line 2680:
> 
>> 2678:         break;
>> 2679:       case Op_VecX:
>> 2680: #ifndef _LP64
> 
> Here and in following code you left code for 32-bit instead of 64-bits.

Oh (facepalms). I guess the lesson here is not touch .ad very late at night :) Reverted to hopefully proper form. I looked through the patch again, and I think these 4 adjacent hunks are the only place I made this mistake.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24300#discussion_r2030720354


More information about the hotspot-compiler-dev mailing list