RFR: 8353665: RISC-V: IR verification fails in TestSubNodeFloatDoubleNegation.java [v3]
Hamlin Li
mli at openjdk.org
Mon Apr 7 12:05:11 UTC 2025
> Hi,
> Can you help to review this patch?
> The newly added TestSubNodeFloatDoubleNegation.java (in https://github.com/openjdk/jdk/pull/24150) is to check `0 - (0 - x)` is not folded to `x` for float and double.
> I have manually checked the IR and generated assembly code, it's not folded on riscv either, just there is an extra SubF in some code path.
> So, the fix for this test on riscv should be simply make the check as `>= 2` rather than `2`.
>
> Tested on both x86 and riscv64.
>
> Thanks
Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
Update test/hotspot/jtreg/compiler/floatingpoint/TestSubNodeFloatDoubleNegation.java
Co-authored-by: Manuel Hässig <manuel.hassig at oracle.com>
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24421/files
- new: https://git.openjdk.org/jdk/pull/24421/files/abb3d548..9ed51e29
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24421&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24421&range=01-02
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/24421.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24421/head:pull/24421
PR: https://git.openjdk.org/jdk/pull/24421
More information about the hotspot-compiler-dev
mailing list