RFR: 8325467: Support methods with many arguments in C2 [v16]

Daniel Lundén dlunden at openjdk.org
Mon Apr 7 15:18:48 UTC 2025


On Mon, 7 Apr 2025 06:52:01 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update comments
>>  - Revise TestNestedSynchronize to make use of CompileFramework
>
> src/hotspot/share/adlc/formsopt.cpp line 180:
> 
>> 178:   //   in the register mask regardless of how much slack is created by rounding.
>> 179:   //   This was found necessary after adding 16 new registers for APX.
>> 180:   return (words_for_regs + 3 + 1 + 1) & ~1;
> 
> Is the comment above still accurate? Specifically this:
> 
>   // on the stack (stack registers) up to some interesting limit.  Methods
>   // that need more parameters will NOT be compiled.  On Intel, the limit
>   // is something like 90+ parameters.
> 
> And if not: might there be other comments around like this?

Thanks, good catch. Now fixed and I also searched for "NOT be compiled" and found no other relevant occurrences.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20404#discussion_r2031470061


More information about the hotspot-compiler-dev mailing list