RFR: 8353551: C2: Constant folding for ReverseBytes nodes [v2]

Hannes Greule hgreule at openjdk.org
Tue Apr 8 08:15:56 UTC 2025


On Tue, 8 Apr 2025 01:26:26 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Hannes Greule has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add test cases with negative -> non-negative
>
> test/hotspot/jtreg/compiler/c2/irTests/ReverseBytesConstantsTests.java line 72:
> 
>> 70:     @DontCompile
>> 71:     public void assertResultI() {
>> 72:         Asserts.assertEQ(Integer.reverseBytes(0x04030201), testI1());
> 
> Please, add more test cases (specifically, with negative constants).

I added cases with a leading 0x80 byte now

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24382#discussion_r2032648072


More information about the hotspot-compiler-dev mailing list