RFR: 8353665: RISC-V: IR verification fails in TestSubNodeFloatDoubleNegation.java [v3]

Ludovic Henry luhenry at openjdk.org
Tue Apr 8 12:46:27 UTC 2025


On Mon, 7 Apr 2025 12:05:11 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review this patch?
>> The newly added TestSubNodeFloatDoubleNegation.java (in https://github.com/openjdk/jdk/pull/24150) is to check `0 - (0 - x)` is not folded to `x` for float and double.
>> I have manually checked the IR and generated assembly code, it's not folded on riscv either, just there is an extra SubF in some code path.
>> So, the fix for this test on riscv should be simply make the check as `>= 2` rather than `2`.
>> 
>> Tested on both x86 and riscv64.
>> 
>> Thanks
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update test/hotspot/jtreg/compiler/floatingpoint/TestSubNodeFloatDoubleNegation.java
>   
>   Co-authored-by: Manuel Hässig <manuel.hassig at oracle.com>

Marked as reviewed by luhenry (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/24421#pullrequestreview-2749843280


More information about the hotspot-compiler-dev mailing list