RFR: 8353665: RISC-V: IR verification fails in TestSubNodeFloatDoubleNegation.java
Hamlin Li
mli at openjdk.org
Tue Apr 8 13:02:25 UTC 2025
On Fri, 4 Apr 2025 13:19:01 GMT, Manuel Hässig <duke at openjdk.org> wrote:
>> Hi,
>> Can you help to review this patch?
>> The newly added TestSubNodeFloatDoubleNegation.java (in https://github.com/openjdk/jdk/pull/24150) is to check `0 - (0 - x)` is not folded to `x` for float and double.
>> I have manually checked the IR and generated assembly code, it's not folded on riscv either, just there is an extra SubF in some code path.
>> So, the fix for this test on riscv should be simply make the check as `>= 2` rather than `2`.
>>
>> Tested on both x86 and riscv64.
>>
>> Thanks
>
> Filed [JDK-8353730](https://bugs.openjdk.org/browse/JDK-8353730). I will first fix the test and then investigate the additional `SubF`.
Thanks for your reviews @mhaessig @TobiHartmann @luhenry !
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24421#issuecomment-2786355103
More information about the hotspot-compiler-dev
mailing list