Integrated: 8353665: RISC-V: IR verification fails in TestSubNodeFloatDoubleNegation.java

Hamlin Li mli at openjdk.org
Tue Apr 8 13:02:26 UTC 2025


On Thu, 3 Apr 2025 16:57:19 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you help to review this patch?
> The newly added TestSubNodeFloatDoubleNegation.java (in https://github.com/openjdk/jdk/pull/24150) is to check `0 - (0 - x)` is not folded to `x` for float and double.
> I have manually checked the IR and generated assembly code, it's not folded on riscv either, just there is an extra SubF in some code path.
> So, the fix for this test on riscv should be simply make the check as `>= 2` rather than `2`.
> 
> Tested on both x86 and riscv64.
> 
> Thanks

This pull request has now been integrated.

Changeset: 21db0fdb
Author:    Hamlin Li <mli at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/21db0fdbfb019b9a7c6613e190ad457278f29582
Stats:     11 lines in 2 files changed: 7 ins; 2 del; 2 mod

8353665: RISC-V: IR verification fails in TestSubNodeFloatDoubleNegation.java

Reviewed-by: thartmann, luhenry

-------------

PR: https://git.openjdk.org/jdk/pull/24421


More information about the hotspot-compiler-dev mailing list