RFR: 8353842: C2: Add graph dumps before and after loop opts phase [v3]

Manuel Hässig duke at openjdk.org
Tue Apr 8 14:10:42 UTC 2025


On Tue, 8 Apr 2025 13:43:18 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Manuel Hässig has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix capitalization
>
> test/hotspot/jtreg/compiler/lib/ir_framework/CompilePhase.java line 61:
> 
>> 59:     ITER_GVN_BEFORE_EA("Iter GVN before EA"),
>> 60:     ITER_GVN_AFTER_VECTOR("Iter GVN after vector box elimination"),
>> 61:     BEFORE_LOOP_OPTS("Before loop optimizations"),
> 
> To match capital first letters of (most) other phases:
> Suggestion:
> 
>     BEFORE_LOOP_OPTS("Before Loop Optimizations"),

Fixed in [951c516](https://github.com/openjdk/jdk/pull/24509/commits/951c516e60f248627770df058df07aa6a0a08b48) and also fixed in `phasetype.cpp`

> test/hotspot/jtreg/compiler/lib/ir_framework/CompilePhase.java line 99:
> 
>> 97:     ITER_GVN2("Iter GVN 2"),
>> 98:     PHASEIDEALLOOP_ITERATIONS("PhaseIdealLoop iterations"),
>> 99:     AFTER_LOOP_OPTS("After loop optimizations"),
> 
> Suggestion:
> 
>     AFTER_LOOP_OPTS("After Loop Optimizations"),

Fixed in [951c516](https://github.com/openjdk/jdk/pull/24509/commits/951c516e60f248627770df058df07aa6a0a08b48) and also fixed in `phasetype.cpp`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24509#discussion_r2033283987
PR Review Comment: https://git.openjdk.org/jdk/pull/24509#discussion_r2033285053


More information about the hotspot-compiler-dev mailing list