RFR: 8351833: Unexpected increase in live nodes when splitting Phis through MergeMems in PhiNode::Ideal [v2]

[Daniel Lundén]

On Thu, 10 Apr 2025 11:56:53 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clean up code related to eager transformation and rename itergvn to igvn
>
> src/hotspot/share/opto/phaseX.cpp line 1037:
> 
>> 1035:   // Pull from worklist and transform the node. If the node has changed,
>> 1036:   // update edge info and put uses on worklist.
>> 1037:   while(_worklist.size()) {
> 
> I guess we could fix that here as well to be explicit:
> Suggestion:
> 
>   while (_worklist.size() > 0) {

Sure, I committed the suggestion!

> test/hotspot/jtreg/compiler/igvn/TestSplitPhiThroughMergeMem.java line 42:
> 
>> 40:  */
>> 41: 
>> 42: package compiler.itergvn;
> 
> You should also update the package name accordingly
> 
> Suggestion:
> 
>  * @run main/othervm -Xbatch
>  *                   -XX:CompileCommand=CompileOnly,compiler.igvn.TestSplitPhiThroughMergeMem::test
>  *                   compiler.igvn.TestSplitPhiThroughMergeMem
>  * @run main compiler.igvn.TestSplitPhiThroughMergeMem
>  */
> 
> package compiler.igvn;

Oops, thanks Christian... committed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24325#discussion_r2037190042
PR Review Comment: https://git.openjdk.org/jdk/pull/24325#discussion_r2037190758