RFR: 8346552: C2: Add IR tests to check that Parse Predicate cloning in Loop Unswitching works as expected [v2]

[Manuel Hässig]

On Thu, 10 Apr 2025 12:23:43 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Manuel Hässig has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - ir-framework: use new before/after loop opts phases
>>  - Merge branch 'master' into JDK-8346552-predicate-cloning
>>  - Add IR test for predicate cloning
>>  - ir-framework: make the parse predicate node regex more robust
>>  - ir-framework: add auto vectorization check node
>>  - ir-framework: add opaque template assertion predicate node
>
> test/hotspot/jtreg/compiler/loopopts/TestUnswitchPredicateCloning.java line 43:
> 
>> 41: 
>> 42:     public static void main(String[] strArr) {
>> 43:         TestFramework.runWithFlags("-Xcomp");
> 
> Do you really need `-Xcomp` for all compilations? If you only need to have it for the test method, you can add `@Warmup(0)`. In case you would have multiple test methods, you can also use `TestFramework.setDefaultWarmup()`.

Indeed, `@Warmup(0)` does the trick. Fixed it in f2dd35018cf.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24479#discussion_r2037541718