RFR: 8354544: Fix bugs in APX NDD code generation for OpenJDK PR [v2]
Tobias Hartmann
thartmann at openjdk.org
Tue Apr 15 06:24:45 UTC 2025
On Mon, 14 Apr 2025 23:56:53 GMT, Srinivas Vamsi Parasa <sparasa at openjdk.org> wrote:
>> This PR fixes the bugs discovered in the APX NDD code generation PR (#23501) that got integrated into OpenJDK.
>>
>> The following compiler tests uncovered these bugs:
>>
>> test/hotspot/jtreg/compiler/c2/cr6340864/TestLongVect.java
>> test/hotspot/jtreg/compiler/c2/cr7192963/TestLongVect.java
>> test/hotspot/jtreg/compiler/vectorization/runner/BasicLongOpTest.java
>> test/hotspot/jtreg/compiler/vectorapi/TestMaskedMacroLogicVector.java
>>
>> After the bug fixes in this PR, using Intel Software Development Emulator (SDE) it was verified that the above tests are working correctly when using Intel APX.
>
> Srinivas Vamsi Parasa has updated the pull request incrementally with two additional commits since the last revision:
>
> - Merge branch 'apxfix' of https://github.com/vamsi-parasa/jdk into apxfix
> - 8354544: Fix bugs in APX NDD code generation for OpenJDK PR
That looks good to me.
I converted the sub-task to a bug. Please use a more descriptive title and add the failure modes to the description of the JBS issue. Thanks!
-------------
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24637#pullrequestreview-2766951472
More information about the hotspot-compiler-dev
mailing list