RFR: 8354544: Fix bugs in APX NDD code generation for OpenJDK PR [v2]
duke
duke at openjdk.org
Tue Apr 15 21:14:43 UTC 2025
On Mon, 14 Apr 2025 23:56:53 GMT, Srinivas Vamsi Parasa <sparasa at openjdk.org> wrote:
>> This PR fixes the bugs discovered in the APX NDD code generation PR (#23501) that got integrated into OpenJDK.
>>
>> The following compiler tests uncovered these bugs:
>>
>> test/hotspot/jtreg/compiler/c2/cr6340864/TestLongVect.java
>> test/hotspot/jtreg/compiler/c2/cr7192963/TestLongVect.java
>> test/hotspot/jtreg/compiler/vectorization/runner/BasicLongOpTest.java
>> test/hotspot/jtreg/compiler/vectorapi/TestMaskedMacroLogicVector.java
>>
>> After the bug fixes in this PR, **using Intel Software Development Emulator (SDE) it was verified that the above tests are working correctly when using Intel APX.**
>>
>> Below is a representative error for the TEST: compiler/c2/cr6340864/TestLongVect.java
>> STDERR:
>> test_xorc: [0] = 9223372032566684971 != -7818520746908513990
>> test_xorc: [1] = 9223372032566684972 != -7818520746908513987
>> test_xorc: [994] = -9223372032566684979 != 7818520746908514012
>> test_xorc: [995] = -9223372032566684978 != 7818520746908514015
>> test_xorc: [996] = -9223372032566684977 != 7818520746908514014
>> test_xorv: [0] = 9223372032566684971 != -7818520746908513990
>> test_xorv: [1] = 9223372032566684972 != -7818520746908513987
>> test_xorv: [994] = -9223372032566684979 != 7818520746908514012
>> test_xorv: [995] = -9223372032566684978 != 7818520746908514015
>> test_xorv: [996] = -9223372032566684977 != 7818520746908514014
>> test_xora: [0] = 9223372032566684971 != -7818520746908513990
>> test_xora: [1] = 9223372032566684972 != -7818520746908513987
>> test_xora: [2] = 9223372032566684973 != -7818520746908513988
>> test_xora: [3] = 9223372032566684974 != -7818520746908513985
>> test_xora: [4] = 9223372032566684975 != -7818520746908513986
>> FAILED: 15 errors
>> TEST RESULT: Failed. Execution failed: Execution failed
>
> Srinivas Vamsi Parasa has updated the pull request incrementally with two additional commits since the last revision:
>
> - Merge branch 'apxfix' of https://github.com/vamsi-parasa/jdk into apxfix
> - 8354544: Fix bugs in APX NDD code generation for OpenJDK PR
@vamsi-parasa
Your change (at version b1a47149acb871bc2e89de9f716830cb422f8bd0) is now ready to be sponsored by a Committer.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24637#issuecomment-2807529848
More information about the hotspot-compiler-dev
mailing list