RFR: 8353551: C2: Constant folding for ReverseBytes nodes [v4]

[Emanuel Peter]

On Mon, 14 Apr 2025 12:55:15 GMT, Hannes Greule <hgreule at openjdk.org> wrote:

>> This change implements constant folding for ReverseBytes nodes.
>> 
>> Currently, `byteswap` is included transitively by `reverse_bits.hpp`. I'm not sure if this is fine or if I need to add an explicit include there.
>> 
>> I appreciate any reviews and comments.
>
> Hannes Greule has updated the pull request incrementally with one additional commit since the last revision:
> 
>   make function static

Nice, the code looks even better now :)

test/hotspot/jtreg/compiler/c2/irTests/ReverseBytesConstantsTests.java line 23:

> 21:  * questions.
> 22:  */
> 23: package compiler.c2.irTests;

Can you please move the test to a more specific directory?
The `irTests` directory was a bit of a mistake. I think this would make more sense in `test/hotspot/jtreg/compiler/c2/gvn/`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/24382#pullrequestreview-2775104402
PR Review Comment: https://git.openjdk.org/jdk/pull/24382#discussion_r2048560285