RFR: 8349139: C2: Div looses dependency on condition that guarantees divisor not null in counted loop [v5]

Roland Westrelin roland at openjdk.org
Fri Apr 18 14:08:13 UTC 2025


On Thu, 17 Apr 2025 09:19:28 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits:
>> 
>>  - review
>>  - Merge branch 'master' into JDK-8349139
>>  - merge
>>  - Merge branch 'master' into JDK-8349139
>>  - other test + review comment
>>  - Merge branch 'master' into JDK-8349139
>>  - Merge branch 'master' into JDK-8349139
>>  - Merge branch 'master' into JDK-8349139
>>  - fix & test
>
> test/hotspot/jtreg/compiler/controldependency/TestDivDependentOnMainLoopGuard.java line 34:
> 
>> 32:  *                   -XX:+UnlockDiagnosticVMOptions -XX:+StressGCM TestDivDependentOnMainLoopGuard
>> 33:  * @run main/othervm -Xcomp -XX:CompileOnly=TestDivDependentOnMainLoopGuard::* TestDivDependentOnMainLoopGuard
>> 34:  *                    
> 
> Suggestion:
> 
> 
> You got some whitespace issues here, we could just remove the line :)

Thanks. I missed that. Fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23617#discussion_r2050678323


More information about the hotspot-compiler-dev mailing list