RFR: 8350896: Integer/Long.compress gets wrong type from CompressBitsNode::Value [v4]

Jatin Bhateja jbhateja at openjdk.org
Mon Apr 21 06:40:42 UTC 2025


> Hi All,
> 
> This bugfix patch fixes incorrect value computation for Integer/Long. compress APIs.
> 
> Problems occur with a constant input and variable mask where the input's value is equal to the lower bound of the mask value., In this case, an erroneous value range estimation results in a constant value. Existing value routine first attempts to constant fold the compression operation if both input and compression mask are constant values; otherwise, it attempts to constrain the value range of result based on the upper and lower bounds of mask type.
> 
> New IR test covers the issue reported in the bug report along with a case for value range based logic pruning.
> 
> Kindly review and share your feedback.
> 
> Best Regards,
> Jatin

Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8350896
 - Review comments resolutions
 - Review comments resolutions
 - 8350896: Integer/Long.compress gets wrong type from CompressBitsNode::Value

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/23947/files
  - new: https://git.openjdk.org/jdk/pull/23947/files/73e1118e..a4ae0803

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=23947&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23947&range=02-03

  Stats: 380151 lines in 4333 files changed: 106351 ins; 250527 del; 23273 mod
  Patch: https://git.openjdk.org/jdk/pull/23947.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23947/head:pull/23947

PR: https://git.openjdk.org/jdk/pull/23947


More information about the hotspot-compiler-dev mailing list