RFR: 8350896: Integer/Long.compress gets wrong type from CompressBitsNode::Value [v2]

Emanuel Peter epeter at openjdk.org
Mon Apr 21 10:34:49 UTC 2025


On Thu, 10 Apr 2025 06:56:39 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/c2/TestBitCompressValueTransform.java line 2:
>> 
>>> 1: /*
>>> 2:  * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
>> 
>> Ah, I just noticed the test directory. I think we can put it in a more specific location.
>
> There are operation specific tests under compiler/c2 let keep it this way.

But this is about a `Value` optimization, which generally belong under the `gvn` directory. Just because we used to put all tests in one directory does not mean we should continue that practice ;)

We should probably at some point clean up all the tests, and move them to better directories. Putting them already to better directories will reduce the backport issues later on, so please put it somewhere more specific.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23947#discussion_r2052239584


More information about the hotspot-compiler-dev mailing list