RFR: 8353290: C2: Refactor PhaseIdealLoop::is_counted_loop() [v3]

Tue Apr 22 07:45:58 UTC 2025

On Thu, 17 Apr 2025 18:23:20 GMT, Kangcheng Xu <kxu at openjdk.org> wrote:

>> This PR refactors `PhaseIdealLoop::is_counted_loop()` into (mostly) `CountedLoopConverter::is_counted_loop()` and `CountedLoopConverter::convert()` to decouple the detection and conversion code. This enables us to try different loop configurations easily and finally convert once a counted loop is found. 
>> 
>> A nested `PhaseIdealLoop::CountedLoopConverter` class is created to handle the context, but I'm not if this is the best name or place for it. Please let me know what you think.
>> 
>> Blocks [JDK-8336759](https://bugs.openjdk.org/browse/JDK-8336759).
>
> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   WIP: review followups

Was out last week but I'm seeing your last commit mentions WIP. Let me know when it's ready to have another look again :-)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24458#issuecomment-2820447750