RFR: 8315916: assert(C->live_nodes() <= C->max_node_limit()) failed: Live Node limit exceeded [v10]

[Emanuel Peter]

On Wed, 9 Apr 2025 18:17:57 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

>> In the debug build, the assert is triggered during the parsing (before Code_Gen). In the Release build, however, the compilation bails out at `Compile::check_node_count()` during the code generation phase and completes execution without any issues.
>> 
>> When I commented out the assert(C->live_nodes() <= C->max_node_limit()), both the debug and release builds exhibited the same behavior: the compilation bails out during code_gen after building the ideal graph with more than 80K nodes.
>> 
>> The proposed fix will check the live node count and bail out during compilation while building the graph for scalarization of the elements in the array when the live node count crosses the limit of 80K, instead of unnecessarily building the entire graph and bailing out in code_gen.
>
> Dhamoder Nalla has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - reduce array/node size limts and remove the timeout
>  - reduce array/node size limts and remove the timeout

src/hotspot/share/opto/macro.cpp line 830:

> 828:       }
> 829:       return nullptr;
> 830:     }*/

Ah, it looks like you commented out your fix. That would explain why the GitHub Actions tests are failing ;)

test/hotspot/jtreg/compiler/escapeAnalysis/TestScalarizeBailout.java line 34:

> 32:  *                   -XX:CompileCommand=dontinline,compiler.escapeAnalysis.TestScalarizeBailout::initializeArray
> 33:  *                   -XX:CompileCommand=compileonly,compiler.escapeAnalysis.TestScalarizeBailout::*
> 34:  *                   compiler.escapeAnalysis.TestScalarizeBailout

Could you please add an additional run with fewer flags?
That would allow us to run this test from the outside with for example `-XX:MaxNodeLimit=10000`, and it would not get instantly overwritten by your `-XX:MaxNodeLimit=20000` here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20504#discussion_r2054332200
PR Review Comment: https://git.openjdk.org/jdk/pull/20504#discussion_r2054330655