RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v47]

[Emanuel Peter]

On Tue, 22 Apr 2025 15:30:35 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 61 commits:
>> 
>>  - Merge branch 'master' into unsignedbounds
>>  - Merge branch 'master' into unsignedbounds
>>  - reviews
>>  - Merge branch 'master' into unsignedbounds
>>  - refine comments
>>  - Merge branch 'master' into unsignedbounds
>>  - Merge branch 'master' into unsignedbounds
>>  - harden SimpleCanonicalResult
>>  - number lemmas
>>  - include
>>  - ... and 51 more: https://git.openjdk.org/jdk/compare/0995b940...cdab1911
>
> src/hotspot/share/opto/rangeinference.cpp line 264:
> 
>> 262:     // first_violation is the position of the violation counting from the
>> 263:     // highest bit down (0-based), since i == 2, first_difference == 1
>> 264:     juint first_violation = count_leading_zeros(one_violation); // 1
> 
> Suggestion:
> 
>     juint first_violation = count_leading_zeros(one_violation);
> 
> What was the comment for?

Ah, you want to say that `first_violation == 1`. Well you already say that above for the example... so not necessary I would say.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r2054372188