RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v47]

Emanuel Peter epeter at openjdk.org
Tue Apr 22 16:15:18 UTC 2025


On Tue, 22 Apr 2025 15:57:55 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/rangeinference.cpp line 280:
>> 
>>> 278:     // This means that the first bit that does not satisfy the bit requirement
>>> 279:     // is a 1 that should be a 0. Trace backward to find i which is the last
>>> 280:     // bit that is 0 in both lo and zeros.
>> 
>> Does this `i` have a name below? What value does it have in the example?
>
> And why is this number relevant?

Ah yes, I see you name it again. But maybe it could be good to give some intuition / motivation why this `i` is relevant.

Maybe something along the line of "which is the bit we need to flip", see comments below?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r2054432423


More information about the hotspot-compiler-dev mailing list