RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v48]
Quan Anh Mai
qamai at openjdk.org
Tue Apr 22 16:41:21 UTC 2025
On Tue, 22 Apr 2025 16:19:55 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Explain what alignment means
>
> src/hotspot/share/opto/rangeinference.cpp line 84:
>
>> 82: // Find the minimum value that is not less than lo and satisfies bits. If there
>> 83: // does not exist one such number, the calculation will overflow and return a
>> 84: // value < lo.
>
> I'm wondering if we should say anything more specific for this case. Maybe at least an example? It should probably not go here at the beginning, but somewhere further down.
What do you mean? It is the doc for `adjust_lo`, of course it needs to be here, I think it is logical to say what the function does before saying how it does it. For that purpose I think it is very clear already and an example is not needed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r2054473778
More information about the hotspot-compiler-dev
mailing list