RFR: 8348638: Performance regression in Math.tanh [v6]
Mohamed Issa
duke at openjdk.org
Wed Apr 23 16:30:51 UTC 2025
On Wed, 23 Apr 2025 09:08:54 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Mohamed Issa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Restructure tanh micro-benchmarks
>
> test/micro/org/openjdk/bench/java/lang/MathBench.java line 68:
>
>> 66:
>> 67: @Param({"-2.0", "-1.0", "-0.5", "-0.1", "0.0", "0.1", "0.5", "1.0", "2.0"})
>> 68: public double tanhConstInput;
>
> The field is not a static final. So inputs to tanh will not be constant values.
Thanks for pointing this out. They should now be constant values. If there are constants required, please let me know.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23889#discussion_r2056436474
More information about the hotspot-compiler-dev
mailing list