RFR: 8355293: [TEST] RISC-V: enable more ir tests [v2]
Fei Yang
fyang at openjdk.org
Thu Apr 24 02:53:50 UTC 2025
On Tue, 22 Apr 2025 15:09:59 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Hi,
>> Can you help to review this simple patch?
>> It just enables some test to run on riscv.
>>
>> Thanks
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>
> copyright
Thanks for doing that. I only have one minor comment.
test/hotspot/jtreg/compiler/loopopts/superword/ProdRed_Double.java line 94:
> 92: @IR(applyIfPlatform = {"riscv64", "true"},
> 93: applyIf = {"SuperWordReductions", "true"},
> 94: failOn = {IRNode.MUL_REDUCTION_VF})
I think we can just leave this two test files (`ProdRed_Float.java`/`ProdRed_Double.java`) untouched?
The IR check is only enabled for x86 sse2 target for now. It does not apply to other CPUs. So I don't see why RISC-V is special here.
-------------
PR Review: https://git.openjdk.org/jdk/pull/24797#pullrequestreview-2789275875
PR Review Comment: https://git.openjdk.org/jdk/pull/24797#discussion_r2057301732
More information about the hotspot-compiler-dev
mailing list