RFR: 8258229: Crash in nmethod::reloc_string_for

[Manuel Hässig]

On Wed, 23 Apr 2025 15:28:12 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> ## Issue Summary
>> 
>> The issue manifests in intermittent failures of test cases with `-XX:+PrintAssembly`. The reason for these intermittent failures is a deoptimization of the method before or during printing its assembly. In case that deoptimization makes the method not entrant, then the entry of that method is patched, but the relocation information is not updated. If the instruction at the method entry before patching had relocation info that prints a comment during assembly printing, printing that comment for the patched entry fails in case the operands of the original and patched instructions do not match.
>> 
>> ## Change Summary
>> 
>> To fix this issue, this PR updates the relocation info when patching the method entry. To avoid any races between printing and deoptimizing, this PR acquires the`NMethodState_lock`for printing an `nmethod`.
>> 
>> All changes of this PR summarized:
>>  - add a regression test,
>>  - update the relocation information after patching the method entry for making it not entrant,
>>  - acquire the `NMethodStat_lock` in `print_nmethod()` to avoid changing the relocation information during printing.
>> 
>> ## Testing
>> 
>> I ran tiers 1 through 3 and Oracle internal testing.
>
> src/hotspot/cpu/x86/nativeInst_x86.cpp line 389:
> 
>> 387: void NativeJump::patch_verified_entry(address entry, address verified_entry, address dest) {
>> 388:   // complete jump instruction (to be inserted) is in code_buffer;
>> 389:   union {
> 
> Do you need this change? Meaning, does it add substantially to this fix? Looks like it does not?
> 
> I'd omit it here, so the patch is cleanly backportable. We will cleanup the remnants of x86_32 port in due course.

I don't need it. I'll take it out before the RFR. Thanks for pointing it out!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24831#discussion_r2056812730