Integrated: 8352620: C2: rename MemNode::memory_type() to MemNode::value_basic_type()
Saranya Natarajan
duke at openjdk.org
Thu Apr 24 09:36:04 UTC 2025
On Thu, 3 Apr 2025 21:06:17 GMT, Saranya Natarajan <duke at openjdk.org> wrote:
> Description: The current name MemNode::memory_type() is misleading because the returned type is a property of the value that is loaded/stored, not the memory that is accessed. Usually, the two of them match, but for mismatched memory accesses (arising e.g. from using Unsafe or memory segments) they might differ, e.g. one might store a value of type 'short' into an array of elements of type 'long'. The proposal was to rename MemNode::memory_type() to MemNode::value_basic_type() to clarify these cases.
>
> Solution: Replaced all occurrence of MemNode::memory_type() with MemNode::value_basic_type()
This pull request has now been integrated.
Changeset: 74a2c831
Author: Saranya Natarajan <saranya.natarajan at oracle.com>
Committer: Roberto Castañeda Lozano <rcastanedalo at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/74a2c831a2af55c66317ca8aead53fde2a2a6900
Stats: 41 lines in 5 files changed: 4 ins; 0 del; 37 mod
8352620: C2: rename MemNode::memory_type() to MemNode::value_basic_type()
Reviewed-by: rcastanedalo, thartmann
-------------
PR: https://git.openjdk.org/jdk/pull/24427
More information about the hotspot-compiler-dev
mailing list