RFR: 8355293: [TEST] RISC-V: enable more ir tests [v2]

Hamlin Li mli at openjdk.org
Thu Apr 24 10:31:40 UTC 2025


On Thu, 24 Apr 2025 10:20:02 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> I added these `failOn` checks for several reasons:
>> 1. It's more clear for user reading the code in the future why we have Mul Reduction for int/long but not for float/double.
>> 2. catch any *wrong* attemp to implement these instructs in the future, unless we have an efficient way to implement the ordered computation. For this one, we could catch it manually by reviewing code, but it's always better to do it automatically.
>
> Ah, I see. There is a `ProdRed_Int.java` test there in the same directory. Then should we check for `MUL_REDUCTION_VD` instead of `MUL_REDUCTION_VF`? We are operating on doubles here.

Thanks for catching!
To confirm, do you mean the line 111 in this file? I'll fix it.
Or you suggest some fix in ProdRed_Int.java too?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24797#discussion_r2058062206


More information about the hotspot-compiler-dev mailing list