RFR: 8355432: Remove CompileTask from SA
Aleksey Shipilev
shade at openjdk.org
Thu Apr 24 14:50:57 UTC 2025
On Wed, 23 Apr 2025 17:14:17 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> A lot of SA infrastructure was added to support SA compiler replay with [JDK-7088955](https://bugs.openjdk.org/browse/JDK-7088955). With [JDK-8315488](https://bugs.openjdk.org/browse/JDK-8315488), we got rid from the most of it. `CompileTask` seems to be left behind. Nothing uses it in SA now.
>
> Now, for Leyden, we want to massage `CompileTask` for better performance and reliability ([JDK-8231269](https://bugs.openjdk.org/browse/JDK-8231269)), and keeping `CompileTask` in SA would require us to implement a whole bunch of complicated, but unnecessary code.
>
> So, it would be good to purge `CompileTask` from SA.
>
> Note that I left the related `vmStructs` definitions, because async-profiler uses those; I think to see which methods current compiler is compiling. That use looks safe, as it polls the task from the already set up ciEnv. async-profiler would need to re-adjust after [JDK-8231269](https://bugs.openjdk.org/browse/JDK-8231269) makes relevant changes in `vmStructs`. This PR frees us from doing the same thing in SA.
Thanks for reviews! I think we are good to go.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24832#issuecomment-2827914359
More information about the hotspot-compiler-dev
mailing list