RFR: 8346836: C2: Verify CastII/CastLL bounds at runtime [v10]
Quan Anh Mai
qamai at openjdk.org
Thu Apr 24 16:12:47 UTC 2025
On Thu, 24 Apr 2025 06:24:06 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
>>
>> - Reconstruct FP
>> - aarch64 support
>> - Merge branch 'master' into verifycast
>> - assert CastLL
>> - reviews
>> - make the flag diagnostic
>> - Merge branch 'master' into verifycast
>> - draft
>> - Merge branch 'master' into verifycast
>> - Merge branch 'master' into verifycast
>> - ... and 6 more: https://git.openjdk.org/jdk/compare/9195a811...8d140fd9
>
> test/hotspot/jtreg/compiler/c2/TestVerifyConstraintCasts.java line 28:
>
>> 26: * @bug 8346836
>> 27: * @requires vm.debug == true & vm.flavor == "server"
>> 28: * @summary Run with -Xcomp to test -XX:+StressGCM -XX:VerifyConstraintCasts=1 in debug builds.
>
> Nit: you are also running it with `-XX:VerifyConstraintCasts=1`. I would just keep the summary more generic.
> Suggestion:
>
> * @summary Empty main program to run with flag VerifyConstraintCasts.
Thanks, I have done so
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22880#discussion_r2058798271
More information about the hotspot-compiler-dev
mailing list