RFR: 8353786: Migrate Vector API math library support to FFM API [v12]
Vladimir Ivanov
vlivanov at openjdk.org
Thu Apr 24 23:29:29 UTC 2025
On Thu, 24 Apr 2025 11:33:43 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> FTR both `VectorSupport.getMaxLaneCount()` and `CPUFeatures` don't rely on raw list of ISA extensions CPU supports, but only those reported by the JVM. So, if some feature support is disabled on JVM side, it won't be reported by `VM_Version` and, hence, `CPUFeatures`.
>
> Thank you for updating! Looks good for riscv. I have ran some basic tests for vector API, passed. I did not ran benchmark, as riscv & aarch64 share the same way to bridge from java to sleef.
>
>> Does the following check catch UseRVV == false case on RISC-V?
>
> Yes. If you don't mind, an explicit comment might be helpful. As to me "lacking vector support" here means the vector length is not large enough, but it's quite subjective, so you are on the call.
>
>> FTR both VectorSupport.getMaxLaneCount() and CPUFeatures don't rely on raw list of ISA extensions CPU supports, but only those reported by the JVM. So, if some feature support is disabled on JVM side, it won't be reported by VM_Version and, hence, CPUFeatures.
>
> I'm fine with this.
Thanks, I added some clarifications in the comments.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24462#discussion_r2059367624
More information about the hotspot-compiler-dev
mailing list