RFR: 8354242: VectorAPI: combine vector not operation with compare [v2]

erifan duke at openjdk.org
Fri Apr 25 07:32:01 UTC 2025


On Thu, 24 Apr 2025 09:39:58 GMT, erifan <duke at openjdk.org> wrote:

>> src/hotspot/share/opto/vectornode.cpp line 2265:
>> 
>>> 2263:     vmcmp = new VectorMaskCastNode(phase->transform(vmcmp), vmcast_vt);
>>> 2264:   }
>>> 2265:   return vmcmp;
>> 
>> It would be preferable if you could kindly re-factor the code such that we only call VectorNode::Ideal once at return to comply with aesthetics of other idealization routines.
>
> Ok, I'll change it in the next commit.

Done, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24674#discussion_r2059702378


More information about the hotspot-compiler-dev mailing list