RFR: 8354242: VectorAPI: combine vector not operation with compare [v2]

[Jatin Bhateja]

On Thu, 24 Apr 2025 09:46:24 GMT, erifan <duke at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/vectorapi/VectorMaskCompareNotTest.java line 38:
>> 
>>> 36:  * @summary test combining vector not operation with compare
>>> 37:  * @modules jdk.incubator.vector
>>> 38:  * @requires ((os.arch!="x86" & os.arch!="i386" & os.arch!="amd64" & os.arch!="x86_64") | vm.cpu.features ~= ".*avx.*")
>> 
>> You can remove this platform limitation and forward the constraints to @IR rules using applyIfCPUFeatureOr
>
> Since this is a platform independent optimization, I tend to use this `@requires` because it's simpler.  If we use `applyIfCPUFeatureOr`, we need to add the same restriction before each test. In addition, if a new architecture supports the vector node, this test may not cover it. What do you think?

I don't see XorVMask implemented on all non-x86 target, like PPC etc..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24674#discussion_r2059923958