RFR: 8355003: Implement Ahead-of-Time Method Profiling
Ioi Lam
iklam at openjdk.org
Sun Apr 27 00:54:47 UTC 2025
On Sat, 26 Apr 2025 23:35:01 GMT, Igor Veresov <iveresov at openjdk.org> wrote:
>> test/hotspot/jtreg/runtime/cds/appcds/aotProfile/AOTProfileFlags.java line 30:
>>
>>> 28: * @requires vm.cds
>>> 29: * @comment work around JDK-8345635
>>> 30: * @requires !vm.jvmci.enabled
>>
>> Consider adding:
>>
>> * @requires vm.cds.supports.aot.class.linking
>> * @requires vm.flagless
>
> Could you please explain why? @iklam, what do you think?
I think it's OK to test without these two additional flags. This will make sure that the two diagnostic flags don't have any bad side effect even if AOT class linking is disabled (due to flags like -XX:+UseZGC).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24886#discussion_r2061892882
More information about the hotspot-compiler-dev
mailing list