RFR: 8355668: RISC-V: jdk/incubator/vector/Int256VectorTests.java fails when using RVV [v4]

Fei Yang fyang at openjdk.org
Mon Apr 28 07:36:48 UTC 2025


On Mon, 28 Apr 2025 07:31:00 GMT, Gui Cao <gcao at openjdk.org> wrote:

>> Hi, After https://github.com/openjdk/jdk/pull/24129, some tests run failed. due to the fact that the later predicate condition overrides the previous one.
>> 
>> ### Testing
>> qemu-system 9.1.50 with UseRVV:
>> 
>> - [x] Run test/jdk/jdk/incubator/vector (fastdebug)
>
> Gui Cao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert instruct name

Good catch! One minor comment. Thanks.

src/hotspot/cpu/riscv/riscv_v.ad line 1130:

> 1128:             (Matcher::vector_element_basic_type(n) == T_INT ||
> 1129:              Matcher::vector_element_basic_type(n) == T_BYTE ||
> 1130:              Matcher::vector_element_basic_type(n) == T_SHORT));

Can you reoder this a bit while you are on it? We always order in size of the type, that is, `T_BYTE`, `T_SHORT` and `T_INT`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/24910#pullrequestreview-2798256737
PR Review Comment: https://git.openjdk.org/jdk/pull/24910#discussion_r2063057057


More information about the hotspot-compiler-dev mailing list