RFR: 8354242: VectorAPI: combine vector not operation with compare [v3]

[erifan]

On Mon, 28 Apr 2025 06:47:38 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> Just a drive-by comment for now, I may review this later more fully.
> 
> > I would also prefer if you added the IR restrictions rather than the JTREG requires.
> > The benefit is that we can still run the tests on all platforms, at least for result verification.
> > Imagine someone adds optimizations to a new platform, but does not know about this test here. They make a mistake, and there is a bug, leading either to a crash or wrong result. With the requires, you test would never even run, and we would not catch it. With the IR applyIf, we would catch the bug.
> 
> Just copy pasting the IR applyIf everywhere is not that much work, and adding in a new platform later is not really hard either.

Thanks! The problem is that when a new platform is added, people may not even know there is a test.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24674#issuecomment-2834280547