RFR: 8345485: C2 MergeLoads: merge adjacent array/native memory loads into larger load [v12]

[kuaiwei]

On Thu, 17 Apr 2025 09:59:03 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> kuaiwei has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:
>> 
>>  - Merge remote-tracking branch 'origin/master' into dev/merge_loads
>>  - Remove unused code
>>  - Move code to addnode.cpp and add more tests
>>  - Merge remote-tracking branch 'origin/master' into dev/merge_loads
>>  - Fix test
>>  - Add more tests
>>  - Enable StressIGVN and riscv platform
>>  - Change tests as review comments
>>  - Fix test failure and change for review comments
>>  - Revert extract value and add more tests
>>  - ... and 4 more: https://git.openjdk.org/jdk/compare/660b17a6...f6518b26
>
> src/hotspot/share/opto/addnode.cpp line 916:
> 
>> 914: 
>> 915: bool MergePrimitiveLoads::is_supported_combine_opcode(int opc) {
>> 916:   return opc == Op_OrI || opc == Op_OrL;
> 
> Ah, and here you do it "positively". I would also recommend using a switch case, it is nicer to extend later for AND and XOR.

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24023#discussion_r2063688262