RFR: 8316694: Implement relocation of nmethod within CodeCache [v13]

Chad Rakoczy duke at openjdk.org
Mon Apr 28 19:30:54 UTC 2025


On Fri, 25 Apr 2025 19:10:27 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

>> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix branch range check
>
> src/hotspot/share/code/relocInfo.cpp line 379:
> 
>> 377:   } else {
>> 378:     // Reassert the callee address, this time in the new copy of the code.
>> 379:     pd_set_call_destination(callee);
> 
> if (src->contains(callee)) {
>     // ...
>     int offset = pointer_delta_as_int(callee, orig_addr);
>     callee = addr() + offset;
>  }
>  pd_set_call_destination(callee);

I'll use this refactor to remove the else but can't use `pointer_delta_as_int` as it only works for positive offsets

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r2064380935


More information about the hotspot-compiler-dev mailing list