RFR: 8347555: [REDO] C2: implement optimization for series of Add of unique value [v7]
Emanuel Peter
epeter at openjdk.org
Tue Apr 29 16:44:53 UTC 2025
On Wed, 23 Apr 2025 16:55:15 GMT, Kangcheng Xu <kxu at openjdk.org> wrote:
>> @tabjy Do you want us to review again? We generally wait for a ping, otherwise we assume you are still working on it ;)
>
> Hello @eme64. I pinged you in [an in-line review](https://github.com/openjdk/jdk/pull/23506#discussion_r2042974649). Could you please provide some commons on this assertion? This is currently blocking my progress and breaking the build. Thank you very much!
@tabjy Thanks for your patience, this one took me longer than I wanted. I responded like this above:
> Hmm, ok I see. Why don't you remove the asserts for now, and we see how clear the code looks now. I think I asked for the consistency check because I was confused by the previous code structure. Maybe it is ok now as it is.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23506#issuecomment-2839557998
More information about the hotspot-compiler-dev
mailing list