RFR: 8355913: RISC-V: improve hotspot/jtreg/compiler/vectorization/runner/BasicFloatOpTest.java

[Fei Yang]

On Tue, 29 Apr 2025 13:42:22 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you help to review this simple patch?
> Previously, BasicFloatOpTest.java is accidently not really enabled on riscv.
> And FmaVF/FmaVD depends on both UseFMA and UseRVV, the code should make it clear in this sense.
> And IR verification of FmaVF in BasicFloatOpTest.java should only be enabled when UseFMA && rvv.
> 
> Thanks!

test/hotspot/jtreg/compiler/vectorization/runner/BasicFloatOpTest.java line 35:

> 33:  * @run main/othervm -Xbootclasspath/a:.
> 34:  *                   -XX:+UnlockDiagnosticVMOptions
> 35:  *                   -XX:+WhiteBoxAPI

This test also covers x86 avx and aarch64 asimd targets. I think UseFMA is also needed for IR checks for these platforms, right? Seems to me more reasonable to add a `-XX:+UseFMA` VM option when running this test. Then we won't need to add all these `applyIf = {"UseFMA", "true"}`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24950#discussion_r2067889769