RFR: 8355913: RISC-V: improve hotspot/jtreg/compiler/vectorization/runner/BasicFloatOpTest.java

[Hamlin Li]

On Wed, 30 Apr 2025 08:16:36 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/vectorization/runner/BasicFloatOpTest.java line 35:
>> 
>>> 33:  * @run main/othervm -Xbootclasspath/a:.
>>> 34:  *                   -XX:+UnlockDiagnosticVMOptions
>>> 35:  *                   -XX:+WhiteBoxAPI
>> 
>> This test also covers x86 avx and aarch64 asimd targets. I think UseFMA is also needed for IR checks for these platforms, right? Seems to me more reasonable to add a `-XX:+UseFMA` VM option when running this test. Then we won't need to add all these `applyIf = {"UseFMA", "true"}`.
>
> I suggest we don't touch other platforms unless I have to do so (e.g. in https://github.com/openjdk/jdk/pull/24947, I have to touch an existing test in another platform), because we need to test it, and it could introduce potential failures, so I won't risk for it.
> 
> For `-XX:+UseFMA`, I suggest we don't add it to the whole test, as there are other IR verifications, which does not depend on it.
> 
> How do you think about it?

And, as you can see `"fma", "true", "avx", "true"`, it's doing the similar thing as riscv.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24950#discussion_r2068189823